Skip to content

CI: Setup github actions #88

Merged
whitequark merged 1 commit intoamaranth-lang:masterfrom
rroohhh:ci
Jul 24, 2020
Merged

CI: Setup github actions #88
whitequark merged 1 commit intoamaranth-lang:masterfrom
rroohhh:ci

Conversation

@rroohhh
Copy link
Copy Markdown
Contributor

@rroohhh rroohhh commented Jul 21, 2020

This should atleast catch trivial typos like #83 and #87.

Currently nmigen-boards requires a unreleased version of nmigen, so I am manually installing it from git.

@FFY00
Copy link
Copy Markdown

FFY00 commented Jul 21, 2020

I think github actions would be better as it does not require any external service and nmigen already uses it, but this is just a nitpick.

@rroohhh
Copy link
Copy Markdown
Contributor Author

rroohhh commented Jul 21, 2020

travis seemed to be used more often throughout the different nmigen repositories, but to me it doesn't really matter which one is used, so I added a github actions configuration aswell.

Comment thread .github/workflows/main.yml Outdated
Comment thread .travis.yml Outdated
This uses "setup.py test" to check if all boards are importable, until
a better solution is found or actual tests are added.
@rroohhh rroohhh changed the title Travis: set up CI builds CI: Setup github actions Jul 22, 2020
@rroohhh rroohhh requested a review from whitequark July 24, 2020 08:35
@whitequark whitequark merged commit 1a3f2b8 into amaranth-lang:master Jul 24, 2020
@whitequark
Copy link
Copy Markdown
Member

Thanks!

@rroohhh rroohhh deleted the ci branch July 24, 2020 08:38
rroohhh pushed a commit to rroohhh/nmigen-boards that referenced this pull request Aug 4, 2020
Currently only done for Synopsys based toolchains (i.e. not nextpnr).

Refs amaranth-lang#88.
rroohhh pushed a commit to rroohhh/nmigen-boards that referenced this pull request Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants