Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csr.event: add event monitor. #16

Merged
merged 1 commit into from Jun 25, 2020

Conversation

jfng
Copy link

@jfng jfng commented Jun 24, 2020

This is a proposal for a CSR-capable version of event.Monitor.

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #16   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         6    +1     
  Lines          630       675   +45     
  Branches       140       142    +2     
=========================================
+ Hits           630       675   +45     
Impacted Files Coverage Δ
nmigen_soc/csr/event.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13a2370...aaa9a58. Read the comment docs.

@@ -0,0 +1,106 @@
# nmigen: UnusedElaboratable=no
Copy link
Author

@jfng jfng Jun 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling the warning in test_csr_event.py is not enough, because self._mux elaboratable defined in .__init__() would also be unused. So I disabled it here too.

@whitequark
Copy link
Member

whitequark commented Jun 25, 2020

Great work, thank you

@whitequark whitequark merged commit 517638c into amaranth-lang:master Jun 25, 2020
3 checks passed
@jfng jfng deleted the csr-event-monitor branch Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants