Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test positional and keyword argument passing #17

Merged
merged 1 commit into from Jun 24, 2020

Conversation

Fatsie
Copy link
Contributor

@Fatsie Fatsie commented Jun 24, 2020

When functions support positional argument passing both passing the
argument by position and by keyword is part of the API. Using both call
methods in the unit tests for such arguments will detect possible future
backwards compatibility breakage.

When functions support positional argument passing both passing the
argument by position and by keyword is part of the API. Using both call
methods in the unit tests for such arguments will detect possible future
backwards compatibility breakage.
@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #17   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          630       630           
  Branches       140       140           
=========================================
  Hits           630       630           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13a2370...f840f68. Read the comment docs.

@whitequark whitequark merged commit 0385d67 into amaranth-lang:master Jun 24, 2020
3 checks passed
@whitequark
Copy link
Member

whitequark commented Jun 24, 2020

Thanks!

@Fatsie Fatsie deleted the test_pos_keyword_arg branch Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants