Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make nmigen 0.3+ compatible #23

Merged
merged 1 commit into from Jul 20, 2020
Merged

Conversation

@rroohhh
Copy link
Contributor

@rroohhh rroohhh commented Jul 17, 2020

No description provided.

@codecov
Copy link

@codecov codecov bot commented Jul 17, 2020

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          693       693           
  Branches       145       145           
=========================================
  Hits           693       693           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1218e26...bc62fc3. Read the comment docs.

@rroohhh
Copy link
Contributor Author

@rroohhh rroohhh commented Jul 17, 2020

This also requires bumping the minimum required nmigen version to 0.2 I think.
Is this acceptable? If not I think the the nmigen dependency should be tightened to not allow anything >0.2

@whitequark
Copy link
Member

@whitequark whitequark commented Jul 17, 2020

Bumping the dependency is fine.

and bump minimum nmigen version to 0.2
@rroohhh
Copy link
Contributor Author

@rroohhh rroohhh commented Jul 17, 2020

Ok

@whitequark whitequark merged commit c754caf into amaranth-lang:master Jul 20, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants