Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create_missing_domain uses platform.request() in deprecated mode in all platforms #1402

Closed
whitequark opened this issue Jun 17, 2024 · 0 comments · Fixed by #1443
Closed

create_missing_domain uses platform.request() in deprecated mode in all platforms #1402

whitequark opened this issue Jun 17, 2024 · 0 comments · Fixed by #1443
Labels
bug meta:help-wanted platform:all
Milestone
0.6

Comments

@whitequark
Copy link
Member

This includes the default implementation.

It should use request(..., dir="-") and create an IO buffer explicitly.
@whitequark whitequark added this to the 0.6 milestone Jun 17, 2024
@whitequark whitequark mentioned this issue Jun 17, 2024
Merged
whitequark added a commit to whitequark/glasgow that referenced this issue Jun 29, 2024
@whitequark
target.hardware: work around amaranth-lang/amaranth#1402.
ecf24a5
github-merge-queue bot pushed a commit to GlasgowEmbedded/glasgow that referenced this issue Jun 29, 2024
@whitequark
target.hardware: work around amaranth-lang/amaranth#1402.
eb2b96a
wanda-phi added a commit to wanda-phi/amaranth that referenced this issue Jun 30, 2024
@wanda-phi
build, vendor: use dir="-" in create_missing_domain.
0697556 
Fixes amaranth-lang#1402.
@wanda-phi wanda-phi mentioned this issue Jun 30, 2024
Merged
wanda-phi added a commit to wanda-phi/amaranth that referenced this issue Jun 30, 2024
@wanda-phi
build, vendor: use dir="-" in create_missing_domain.
23a1813 
Fixes amaranth-lang#1402.
github-merge-queue bot pushed a commit that referenced this issue Jun 30, 2024
@wanda-phi @whitequark
build, vendor: use dir="-" in create_missing_domain.
eefca83 
Fixes #1402.
whitequark pushed a commit that referenced this issue Jun 30, 2024
@wanda-phi @whitequark
build, vendor: use dir="-" in create_missing_domain.
abb80b6 
Fixes #1402.
whitequark added a commit to whitequark/glasgow that referenced this issue Jul 23, 2024
@whitequark
target.hardware: remove workaround for amaranth-lang/amaranth#1402.
52f414d 
Not necessary since Amaranth 0.5.1.
github-merge-queue bot pushed a commit to GlasgowEmbedded/glasgow that referenced this issue Jul 23, 2024
@whitequark
target.hardware: remove workaround for amaranth-lang/amaranth#1402.
fbe6c9d 
Not necessary since Amaranth 0.5.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug meta:help-wanted platform:all
Milestone
0.6
Development

Successfully merging a pull request may close this issue.

build, vendor: use dir="-" in create_missing_domain. wanda-phi/amaranth
1 participant
@whitequark