Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nmigen-yosys versions are internally inconsistent #491

Closed
whitequark opened this issue Aug 27, 2020 · 1 comment
Closed

nmigen-yosys versions are internally inconsistent #491

whitequark opened this issue Aug 27, 2020 · 1 comment

Comments

@whitequark
Copy link
Member

@whitequark whitequark commented Aug 27, 2020

For annoying reasons, the setuptools_scm version of nmigen-yosys does not match the Yosys node version:

 nMigen Yosys 0.9+3527 (PyPI ver 0.9.post4831.dev23, git sha1 a0177569)

We detect features based on the Yosys node version. There is some code that parses the setuptools_scm version in _toolchain.yosys, and it is broken with the currently published nmigen-yosys packages because the versions don't match.

The reason this code parses the Python package version rather than the -V output version is wasmtime's startup latency: I did run python3 -m nmigen-yosys -V at one point, but the performance hit felt unacceptable.

I think the only reasonable way to handle this is to stop using setuptools_scm to get Yosys version and just shell out to git. We must do this before shipping the next release, since our backends already require recent node versions.

@whitequark
Copy link
Member Author

@whitequark whitequark commented Aug 27, 2020

Done and verified on CI.

Since the Yosys node vesion is less than the setuptools_scm version, I had to go and (manually...) delete every nmigen-yosys package ever released. Why delete and not yank? Because of this pip issue.

@whitequark whitequark closed this Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant