Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't represent simulation time as floating point #535

Closed
whitequark opened this issue Nov 7, 2020 · 0 comments · Fixed by #651
Closed

Don't represent simulation time as floating point #535

whitequark opened this issue Nov 7, 2020 · 0 comments · Fixed by #651

Comments

@whitequark
Copy link
Member

whitequark commented Nov 7, 2020

There's really no excuse for implementing it that way in the first place, and we should just fix it. /cc @mwkmwkmwk

modwizcode added a commit to modwizcode/amaranth that referenced this issue Dec 13, 2021
Using floats to represent simulation time internally isn't ideal
instead use 100ps internal units while continuing to use a floating
point based interface for compatibility.

Fixes amaranth-lang#535.
modwizcode added a commit to modwizcode/amaranth that referenced this issue Dec 13, 2021
Using floats to represent simulation time internally isn't ideal
instead use 100ps internal units while continuing to use a floating
point based interface for compatibility.

Fixes amaranth-lang#535.
modwizcode added a commit to modwizcode/amaranth that referenced this issue Dec 13, 2021
Using floats to represent simulation time internally isn't ideal
instead use 100ps internal units while continuing to use a floating
point based interface for compatibility.

Fixes amaranth-lang#535.
modwizcode added a commit to modwizcode/amaranth that referenced this issue Dec 13, 2021
Using floats to represent simulation time internally isn't ideal
instead use 100ps internal units while continuing to use a floating
point based interface for compatibility.

Fixes amaranth-lang#535.
modwizcode added a commit to modwizcode/amaranth that referenced this issue Dec 13, 2021
Using floats to represent simulation time internally isn't ideal
instead use 100ps internal units while continuing to use a floating
point based interface for compatibility.

Fixes amaranth-lang#535.
modwizcode added a commit to modwizcode/amaranth that referenced this issue Dec 13, 2021
Using floats to represent simulation time internally isn't ideal
instead use 1ps internal units while continuing to use a floating
point based interface for compatibility.

Fixes amaranth-lang#535.
whitequark pushed a commit that referenced this issue Dec 13, 2021
Using floats to represent simulation time internally isn't ideal
instead use 1ps internal units while continuing to use a floating
point based interface for compatibility.

Fixes #535.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant