Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to suppress code generation comments #572

Closed
hansfbaier opened this issue Jan 5, 2021 · 4 comments
Closed

Add option to suppress code generation comments #572

hansfbaier opened this issue Jan 5, 2021 · 4 comments
Labels
Milestone

Comments

@hansfbaier
Copy link

hansfbaier commented Jan 5, 2021

When generating code, almost every line has code generation comments.
While this is useful for debugging, it makes the code very hard to read.
Therefore it would be great to have a code generation option
to suppress those.

@hellow554
Copy link

hellow554 commented Feb 5, 2021

hey @hansfbaier
you seem to have been working on this issue (according to the three references commits here).
What is your status on this? Are you able to submit a PR?

@hansfbaier
Copy link
Author

hansfbaier commented Feb 6, 2021

@hellow554 : I have this: https://github.com/hansfbaier/nmigen/commit/304ad1ffa2b64fe60cb709d9dad2cb9edaf9d87c
But I am hesitant to create a pull request, because @whitequark seems opposed to having this functionality in nmigen,
see #573

@whitequark
Copy link
Member

whitequark commented Feb 6, 2021

I think the functionality is fine, the implementation just needs to be improved. I apologize for my disproportionally intense reaction, @hansfbaier -- I'll work something out to have this upstream.

@hansfbaier
Copy link
Author

hansfbaier commented Feb 6, 2021

@whitequark Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants