Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad error message when giving Cat strings #614

Closed
anuejn opened this issue May 21, 2021 · 2 comments
Closed

bad error message when giving Cat strings #614

anuejn opened this issue May 21, 2021 · 2 comments
Milestone

Comments

@anuejn
Copy link
Contributor

anuejn commented May 21, 2021

Cat gives a RecursionError when giving it a string.
Probably flatten (from _util.py) should have special casing for strings to fix this.

repro:

from nmigen import Cat
Cat("test")
@whitequark
Copy link
Member

whitequark commented May 21, 2021

I vaguely recall fixing something like that once--not sure what happened with that. In any case, yes, reasonable.

@whitequark
Copy link
Member

whitequark commented Dec 11, 2021

Thanks for the report!

@whitequark whitequark added this to the 0.3 milestone Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants