Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Import migen's genlib.misc into nmigen.compat #323

Closed
wants to merge 2 commits into from

Conversation

awygle
Copy link
Contributor

@awygle awygle commented Feb 16, 2020

No description provided.

@codecov
Copy link

codecov bot commented Feb 16, 2020

Codecov Report

Merging #323 into master will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #323     +/-   ##
=========================================
- Coverage   82.47%   82.18%   -0.3%     
=========================================
  Files          35       35             
  Lines        5884     5782    -102     
  Branches     1193     1190      -3     
=========================================
- Hits         4853     4752    -101     
  Misses        872      872             
+ Partials      159      158      -1
Impacted Files Coverage Δ
nmigen/compat/genlib/fifo.py 72.41% <0%> (-4.06%) ⬇️
nmigen/compat/fhdl/structure.py 63.39% <0%> (-3.81%) ⬇️
nmigen/compat/fhdl/module.py 72.97% <0%> (-2.03%) ⬇️
nmigen/compat/fhdl/bitcontainer.py 75% <0%> (-1.93%) ⬇️
nmigen/build/plat.py 26.72% <0%> (-1.43%) ⬇️
nmigen/_utils.py 79.76% <0%> (-0.92%) ⬇️
nmigen/build/run.py 30.37% <0%> (-0.88%) ⬇️
nmigen/compat/fhdl/specials.py 31.11% <0%> (-0.76%) ⬇️
nmigen/compat/genlib/fsm.py 58.04% <0%> (-0.3%) ⬇️
nmigen/hdl/xfrm.py 96.14% <0%> (-0.15%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ae8791...5844a79. Read the comment docs.

Temporary, while we figure out how to handle them. Should save others
from having to reverse-engineer them.
@awygle awygle changed the title Import migen's genlib.misc into nmigen.compat [WIP] Import migen's genlib.misc into nmigen.compat Feb 16, 2020
@awygle
Copy link
Contributor Author

awygle commented Feb 16, 2020

Need to figure out whether to add corresponding functionality to nmigen, and add depreciation warnings, for all items in genlib.misc.

@awygle
Copy link
Contributor Author

awygle commented Mar 6, 2020

I'm gonna chop this up into much smaller bits at some point, this seems unlikely to be mergeable as is.

@awygle awygle closed this Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant