-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create AsyncFFSynchronizer CDC Primitive #332
Conversation
Also use ReleaseSynchronizer in AsyncFIFO.
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
==========================================
- Coverage 82.56% 82.47% -0.09%
==========================================
Files 35 35
Lines 5884 5913 +29
Branches 1196 1198 +2
==========================================
+ Hits 4858 4877 +19
- Misses 864 876 +12
+ Partials 162 160 -2
Continue to review full report at Codecov.
|
Most prominently, modify platform support to produce AsyncFFSynchronizers with configurable edges rather than ResetSynchronizers.
I do not understand what codecov is complaining about - the details point to blank lines and comments? |
Ignore it. It's only slightly more useful than annoying. We should probably make it less noisy. |
Also document async_edge.
Thank you! |
Per discussion on PR #329, implement
AsyncFFSynchronizer
CDC primitive for async-set-sync-release synchronization and make ResetSynchronizer a wrapper around it if platform-specific support does not exist.