Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create AsyncFFSynchronizer CDC Primitive #332

Merged
merged 9 commits into from
Mar 8, 2020
Merged

Conversation

awygle
Copy link
Contributor

@awygle awygle commented Mar 6, 2020

Per discussion on PR #329, implement AsyncFFSynchronizer CDC primitive for async-set-sync-release synchronization and make ResetSynchronizer a wrapper around it if platform-specific support does not exist.

nmigen/lib/cdc.py Outdated Show resolved Hide resolved
nmigen/lib/cdc.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #332 into master will decrease coverage by 0.08%.
The diff coverage is 86.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
- Coverage   82.56%   82.47%   -0.09%     
==========================================
  Files          35       35              
  Lines        5884     5913      +29     
  Branches     1196     1198       +2     
==========================================
+ Hits         4858     4877      +19     
- Misses        864      876      +12     
+ Partials      162      160       -2     
Impacted Files Coverage Δ
nmigen/hdl/ast.py 87.45% <0.00%> (-1.01%) ⬇️
nmigen/back/pysim.py 91.07% <0.00%> (-0.36%) ⬇️
nmigen/hdl/ir.py 95.41% <0.00%> (+0.25%) ⬆️
nmigen/tracer.py 94.59% <0.00%> (+5.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a14a572...b2f6ab1. Read the comment docs.

Most prominently, modify platform support to produce
AsyncFFSynchronizers with configurable edges rather than
ResetSynchronizers.
@awygle
Copy link
Contributor Author

awygle commented Mar 6, 2020

I do not understand what codecov is complaining about - the details point to blank lines and comments?

nmigen/vendor/intel.py Outdated Show resolved Hide resolved
@whitequark
Copy link
Member

I do not understand what codecov is complaining about - the details point to blank lines and comments?

Ignore it. It's only slightly more useful than annoying. We should probably make it less noisy.

@whitequark whitequark merged commit 2f8669c into amaranth-lang:master Mar 8, 2020
@whitequark
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants