Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using non-compat Elaboratable instances with some compat functions #346

merged 1 commit into from Apr 2, 2020


Copy link

Add support for using non-compat Elaboratable instances with compat.fhdl.verilog.convert and compat.run_simulation

Fixes #344

Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #346 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #346   +/-   ##
  Coverage   82.74%   82.75%           
  Files          35       35           
  Lines        5916     5919    +3     
  Branches     1200     1201    +1     
+ Hits         4895     4898    +3     
  Misses        862      862           
  Partials      159      159           
Impacted Files Coverage Δ
nmigen/compat/fhdl/ 75.00% <100.00%> (+4.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e1145e...f7fa21b. Read the comment docs.

@whitequark whitequark merged commit 995f3a1 into amaranth-lang:master Apr 2, 2020
Copy link

Thanks for the fix!

Copy link
Contributor Author

Wow, that's fast!

@programmerjake programmerjake deleted the fix-run-simulation branch April 2, 2020 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

run_simulation doesn't call elaborate before trying to set domains
2 participants