Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use declarative setuptools config #358

Closed

Conversation

@graingert
Copy link

@graingert graingert commented Apr 15, 2020

No description provided.

setup.cfg Outdated Show resolved Hide resolved
@codecov
Copy link

@codecov codecov bot commented Apr 15, 2020

Codecov Report

Merging #358 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   82.60%   82.60%           
=======================================
  Files          35       35           
  Lines        5955     5955           
  Branches     1210     1210           
=======================================
  Hits         4919     4919           
  Misses        871      871           
  Partials      165      165           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4af217...4c6070d. Read the comment docs.

@graingert graingert force-pushed the use-declarative-setup-config branch from 18f50d2 to 99165bc Apr 15, 2020
local_scheme.py Outdated
@@ -0,0 +1,6 @@
def local_scheme(version):
return (
Copy link
Member

@whitequark whitequark Apr 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use the old code for this function please? The changed version is harder to understand IMO.

Copy link
Author

@graingert graingert Apr 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code has been moved into setuptools-scm-node-and-dirty-tag, it could be moved back inline once pypa/setuptools_scm#418 or pypa/setuptools_scm#419 land

setup.cfg Outdated Show resolved Hide resolved
@whitequark
Copy link
Member

@whitequark whitequark commented Apr 15, 2020

Is setup.py required after these changes, or is it only left for compatibility?

@graingert
Copy link
Author

@graingert graingert commented Apr 15, 2020

@graingert graingert force-pushed the use-declarative-setup-config branch 2 times, most recently from c1a2597 to 87b1be4 Apr 15, 2020
@graingert graingert force-pushed the use-declarative-setup-config branch from 87b1be4 to 4c6070d Apr 15, 2020
@whitequark
Copy link
Member

@whitequark whitequark commented May 3, 2020

Looks like the setuptools_scm maintainer isn't planning to implement the necessary functionality himself (which is perfectly fine!); I don't have time to do that either. Unless someone wants to implement pypa/setuptools_scm#419 I propose we postpone migration to declarative setuptools configuration indefinitely, since there is very little downside to that.

@whitequark
Copy link
Member

@whitequark whitequark commented Jul 1, 2020

Turns out it's actually enough to have a minimal pyproject.toml alone to fix the original issue with the venv command. I've done that in 7fca037.

@graingert Thank you for your effort, even if in the end it was not used. If setuptools_scm ever gains configurable version formats I'll resurrect this PR.

@whitequark whitequark closed this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants