Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] AsyncFIFO: disable read from dual-port Memory when FIFO empty #369

Closed
wants to merge 1 commit into from

Conversation

awygle
Copy link
Collaborator

@awygle awygle commented Apr 24, 2020

Avoids CDC hazard described in issue #217.

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #369 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #369   +/-   ##
=======================================
  Coverage   82.58%   82.58%           
=======================================
  Files          35       35           
  Lines        5962     5962           
  Branches     1213     1213           
=======================================
  Hits         4924     4924           
  Misses        872      872           
  Partials      166      166           
Impacted Files Coverage Δ
nmigen/lib/fifo.py 92.97% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba79b0c...75e87f6. Read the comment docs.

@awygle awygle changed the title AsyncFIFO: disable read from dual-port Memory when FIFO empty [WIP] AsyncFIFO: disable read from dual-port Memory when FIFO empty Apr 24, 2020
@whitequark whitequark marked this pull request as draft July 1, 2020 06:01
@whitequark whitequark force-pushed the master branch 2 times, most recently from c86aaa2 to d71e19e Compare July 22, 2020 09:28
@awygle
Copy link
Collaborator Author

awygle commented Aug 30, 2020

I'm not comfortable doing this until #387 is implemented, so I'm just going to close this for now and put any time I'd have spent on this into that instead.

@awygle awygle closed this Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant