Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve allow_reset_less when remapping ResetSignal. Closes #400 #401

Merged
merged 1 commit into from Jun 6, 2020
Merged

Preserve allow_reset_less when remapping ResetSignal. Closes #400 #401

merged 1 commit into from Jun 6, 2020

Conversation

adamgreig
Copy link
Contributor

@adamgreig adamgreig commented Jun 5, 2020

See #400

@codecov
Copy link

@codecov codecov bot commented Jun 5, 2020

Codecov Report

Merging #401 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
+ Coverage   82.05%   82.10%   +0.04%     
==========================================
  Files          36       36              
  Lines        6075     6075              
  Branches     1234     1234              
==========================================
+ Hits         4985     4988       +3     
+ Misses        915      914       -1     
+ Partials      175      173       -2     
Impacted Files Coverage Δ
nmigen/hdl/xfrm.py 96.24% <100.00%> (ø)
nmigen/hdl/ir.py 95.47% <0.00%> (+0.25%) ⬆️
nmigen/tracer.py 94.59% <0.00%> (+5.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f7c3bf...2aef7dd. Read the comment docs.

@whitequark
Copy link
Member

@whitequark whitequark commented Jun 6, 2020

Could you add a test please?

@adamgreig
Copy link
Contributor Author

@adamgreig adamgreig commented Jun 6, 2020

I've added a test which fails without the change and passes with, though it doesn't explicitly check that the newly created ResetSignal still has allow_reset_less set to True as I wasn't sure how to get at that signal.

@whitequark
Copy link
Member

@whitequark whitequark commented Jun 6, 2020

This test is totally fine, thanks!

@whitequark whitequark merged commit 02e30b5 into amaranth-lang:master Jun 6, 2020
3 checks passed
@adamgreig adamgreig deleted the allow_reset_less branch Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants