Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor/lattice_machxo: suppport machXO3 #408

Merged
merged 4 commits into from Jun 21, 2020
Merged

vendor/lattice_machxo: suppport machXO3 #408

merged 4 commits into from Jun 21, 2020

Conversation

trabucayre
Copy link
Contributor

@trabucayre trabucayre commented Jun 21, 2020

machXO2 and machXO3l have same primitives:

  • rename file : lattice_machxo2 -> lattice_machxo_2_3l
  • rename class: LatticeMachXO2Platform -> LatticeMachXO2Or3lPlatform
  • LatticeMachXO2Platform is now an user-alias
  • add LatticeMachXO3lPlatform user alias

trabucayre added 2 commits Jun 21, 2020
… previous class name as user-alias and add an user-alias for machXO3 platform
README.md Outdated
@@ -43,6 +43,7 @@ nMigen can be used to target any FPGA or ASIC process that accepts behavioral Ve

* Lattice iCE40 (toolchains: **Yosys+nextpnr**, LSE-iCECube2, Synplify-iCECube2);
* Lattice MachXO2 (toolchains: Diamond);
* Lattice MachXO3l (toolchains: Diamond);
Copy link
Member

@whitequark whitequark Jun 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the chip called MachXO3L (capital L)? E.g. in vendor docs.

@codecov
Copy link

codecov bot commented Jun 21, 2020

Codecov Report

Merging #408 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #408   +/-   ##
=======================================
  Coverage   82.02%   82.02%           
=======================================
  Files          36       36           
  Lines        6114     6114           
  Branches     1237     1237           
=======================================
  Hits         5015     5015           
- Misses        923      924    +1     
+ Partials      176      175    -1     
Impacted Files Coverage Δ
nmigen/build/run.py 31.25% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 868d49e...6359a57. Read the comment docs.

@@ -4,10 +4,11 @@
from ..build import *


__all__ = ["LatticeMachXO2Platform"]
__all__ = ["LatticeMachXO2Platform", "LatticeMachXO3lPlatform"]
Copy link
Member

@whitequark whitequark Jun 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everywhere, not just in MachXO3L.

@whitequark whitequark merged commit 0aef5f4 into amaranth-lang:master Jun 21, 2020
3 checks passed
@whitequark
Copy link
Member

whitequark commented Jun 21, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants