Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_yosys.py: handle unparseable versions #411

Merged
merged 3 commits into from Jun 23, 2020
Merged

Conversation

alanvgreen
Copy link
Contributor

@alanvgreen alanvgreen commented Jun 23, 2020

Do not use yosys binaries with unparseable version numbers. This ensures
that nmigen always knows what version of yosys it is generating RTLIL
for.

The effect of this change is that if the version number of the system
yosys is unparsable, nmigen will attempt to fallback to the builtin
Yosys.

Issue #409.

Do not use yosys binaries with unparseable version numbers. This ensures
that nmigen always knows what version of yosys it is generating RTLIL
for.

The effect of this change is that if the version number of the system
yosys is unparsable, nmigen will attempt to fallback to the builtin
Yosys.

Issue amaranth-lang#409.
nmigen/_yosys.py Outdated Show resolved Hide resolved
nmigen/_yosys.py Outdated Show resolved Hide resolved
@codecov
Copy link

@codecov codecov bot commented Jun 23, 2020

Codecov Report

Merging #411 into master will decrease coverage by 0.03%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
- Coverage   82.02%   81.98%   -0.04%     
==========================================
  Files          36       36              
  Lines        6114     6118       +4     
  Branches     1237     1239       +2     
==========================================
+ Hits         5015     5016       +1     
- Misses        924      925       +1     
- Partials      175      177       +2     
Impacted Files Coverage Δ
nmigen/_yosys.py 65.21% <42.85%> (-1.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 706eb03...0e2f5d1. Read the comment docs.

alanvgreen and others added 2 commits Jun 23, 2020
Co-authored-by: whitequark <whitequark@whitequark.org>
Co-authored-by: whitequark <whitequark@whitequark.org>
@alanvgreen
Copy link
Contributor Author

@alanvgreen alanvgreen commented Jun 23, 2020

This is my first github code review - let me know if you'd prefer me to squash these 3 changes into one.

@whitequark whitequark merged commit 303ea18 into amaranth-lang:master Jun 23, 2020
1 of 3 checks passed
@whitequark
Copy link
Member

@whitequark whitequark commented Jun 23, 2020

I've squashed it through GitHub's UI. Thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants