Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't inherit Shape from NamedTuple #422

Merged
merged 5 commits into from Jul 7, 2020
Merged

Conversation

@awygle
Copy link
Collaborator

@awygle awygle commented Jul 6, 2020

Fixes issue #421 .

@codecov
Copy link

@codecov codecov bot commented Jul 6, 2020

Codecov Report

Merging #422 into master will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
- Coverage   81.88%   81.75%   -0.13%     
==========================================
  Files          35       35              
  Lines        6094     6079      -15     
  Branches     1236     1238       +2     
==========================================
- Hits         4990     4970      -20     
- Misses        927      931       +4     
- Partials      177      178       +1     
Impacted Files Coverage Δ
nmigen/hdl/ast.py 88.76% <100.00%> (+0.12%) ⬆️
nmigen/lib/io.py 73.68% <0.00%> (-8.67%) ⬇️
nmigen/back/pysim.py 90.40% <0.00%> (-0.51%) ⬇️
nmigen/build/run.py 31.25% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 175c8a5...1500165. Read the comment docs.

nmigen/hdl/ast.py Outdated Show resolved Hide resolved
@awygle
Copy link
Collaborator Author

@awygle awygle commented Jul 6, 2020

@whitequark whitequark merged commit 659b0e8 into amaranth-lang:master Jul 7, 2020
2 of 3 checks passed
@whitequark
Copy link
Member

@whitequark whitequark commented Jul 7, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants