Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write next state to vcd instead of curr state, since state is written just prior to commit #430

Merged
merged 1 commit into from Jul 13, 2020

Conversation

@programmerjake
Copy link
Contributor

@programmerjake programmerjake commented Jul 13, 2020

Fixes #429

I tested it and it seems to work!
@whitequark You can add a regression test later if you want.

@whitequark
Copy link
Member

@whitequark whitequark commented Jul 13, 2020

So actually a better fix would be to accumulate pending throughout every delta cycle and then write things only once per step. Unless you need this fixed urgently I'd rather do that.

@programmerjake
Copy link
Contributor Author

@programmerjake programmerjake commented Jul 13, 2020

Would you be willing to merge this fix while you finish off the better fix, since this one is pretty simple? I'm not 100% sure, but I think #429 is blocking several people in Libre-SOC to some extent.

@codecov
Copy link

@codecov codecov bot commented Jul 13, 2020

Codecov Report

Merging #430 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
- Coverage   81.72%   81.71%   -0.01%     
==========================================
  Files          40       40              
  Lines        6100     6099       -1     
  Branches     1243     1242       -1     
==========================================
- Hits         4985     4984       -1     
  Misses        935      935              
  Partials      180      180              
Impacted Files Coverage Δ
nmigen/sim/pysim.py 90.62% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30e2f91...abe24c1. Read the comment docs.

@whitequark whitequark merged commit 58f1d4b into amaranth-lang:master Jul 13, 2020
2 of 3 checks passed
@programmerjake
Copy link
Contributor Author

@programmerjake programmerjake commented Jul 13, 2020

Thanks!

@programmerjake programmerjake deleted the fix-429 branch Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants