Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor.xilinx_{7series,ultrascale}: add SIM_DEVICE parameter #444

Merged
merged 1 commit into from Jul 23, 2020

Conversation

@whitequark
Copy link
Member

@whitequark whitequark commented Jul 22, 2020

The parameter defaults to "ULTRASCALE", even when synthesizing for 7-series devices. This could lead to a simulation/synthesis mismatch, and causes a warning.

Fixes #438.

The parameter defaults to "ULTRASCALE", even when synthesizing for
7-series devices. This could lead to a simulation/synthesis mismatch,
and causes a warning.

Fixes #438.
@codecov
Copy link

@codecov codecov bot commented Jul 22, 2020

Codecov Report

Merging #444 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #444   +/-   ##
=======================================
  Coverage   81.68%   81.68%           
=======================================
  Files          40       40           
  Lines        6099     6099           
  Branches     1242     1242           
=======================================
  Hits         4982     4982           
- Misses        936      937    +1     
+ Partials      181      180    -1     
Impacted Files Coverage Δ
nmigen/build/run.py 31.25% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0899ff3...b78e875. Read the comment docs.

@whitequark whitequark force-pushed the master branch 2 times, most recently from c86aaa2 to d71e19e Jul 22, 2020
@whitequark whitequark merged commit c75fa45 into master Jul 23, 2020
6 checks passed
@whitequark whitequark deleted the xilinx-sim_device branch Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant