Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ValueCastable #449

Merged
merged 6 commits into from Nov 6, 2020
Merged

Implement ValueCastable #449

merged 6 commits into from Nov 6, 2020

Conversation

@awygle
Copy link
Collaborator

@awygle awygle commented Jul 24, 2020

Implement the ValueCastable type as described in #355 .

@awygle
Copy link
Collaborator Author

@awygle awygle commented Jul 24, 2020

This PR does not deprecate UserValue. If you'd rather that be included, let me know and I'll add it, but it seemed easier to review them separately.

Likewise it does not move internal usage of UserValue over to ValueCastable.

@whitequark whitequark added this to the 0.3 milestone Aug 27, 2020
awygle added 2 commits Aug 30, 2020
`memoized`->`ValueCastable.lowermethod`, `__memoized__`->`__memoized`
nmigen/hdl/ast.py Outdated Show resolved Hide resolved
nmigen/hdl/ast.py Outdated Show resolved Hide resolved
awygle and others added 2 commits Sep 4, 2020
@awygle
Copy link
Collaborator Author

@awygle awygle commented Sep 4, 2020

That should resolve the as_value subtleties around being an abstract method without using ABCMeta as the metaclass

nmigen/hdl/ast.py Outdated Show resolved Hide resolved
nmigen/hdl/ast.py Show resolved Hide resolved
nmigen/hdl/ast.py Outdated Show resolved Hide resolved
tests/test_hdl_ast.py Outdated Show resolved Hide resolved
nmigen/hdl/ast.py Outdated Show resolved Hide resolved
@codecov
Copy link

@codecov codecov bot commented Nov 5, 2020

Codecov Report

Merging #449 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   81.33%   81.39%   +0.06%     
==========================================
  Files          49       49              
  Lines        6419     6440      +21     
  Branches     1282     1286       +4     
==========================================
+ Hits         5221     5242      +21     
  Misses       1009     1009              
  Partials      189      189              
Impacted Files Coverage Δ
nmigen/hdl/ast.py 89.19% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47ecc16...925a21d. Read the comment docs.

@whitequark whitequark merged commit 06c7349 into amaranth-lang:master Nov 6, 2020
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants