nmigen.lib: Add RoundRobin#450
Conversation
|
Currently implementing @jfng's suggestions (code styling, better doc, etc.). |
…tion test for width=1
…ccount and use varying requests values
| """Round-robin scheduler. | ||
|
|
||
| For a given set of requests, the round-robin scheduler will | ||
| grant one request. |
There was a problem hiding this comment.
I feel like this should be elaborated. Something like (phrasing needs to be improved):
For a given set of requests, the round-robin scheduler will grant one request. Once it grants a request, if any other requests are active, it grants the next active request with a greater number, restarting from zero once it reaches the highest one. Use :class:
EnableInserterto control when the scheduler advances.
There was a problem hiding this comment.
I tweaked a little bit what you wrote. What do you think?
|
Great, thanks for the work! There's only one remaining concern I have: should |
|
That's the way it was in omigen because there was only one scheduler. I seriously doubt that we're going to have other schedulers in nMigen, but just in case we could name the module |
I think we can name the module |
Co-authored-by: whitequark <whitequark@whitequark.org>
Co-authored-by: whitequark <whitequark@whitequark.org>
Fixes #448