Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build,vendor: never carry around parts of differential signals #459

Merged
merged 1 commit into from Jul 31, 2020

Conversation

whitequark
Copy link
Member

When a port component is skipped, it should appear neither in the RTL nor in the constraint file. However, passing around components of differential ports explicitly makes that harder.

Fixes #456.
Supersedes #457.

@whitequark
Copy link
Member Author

@jeanthom PTAL

@awygle @jfng there's some bulk change in this code which is unfortunately not robustly tested, can you give this a look before I merge?

@jeanthom
Copy link

jeanthom commented Jul 31, 2020

Thanks for the PR, I can get #457 to work with it.

@whitequark
Copy link
Member Author

Thanks for the PR, I can get #457 to work with it.

This PR includes #457.

@jeanthom
Copy link

Oh I thought the PR only changed "p_port, n_port" => "port".

When a port component is skipped, it should appear neither in the RTL
nor in the constraint file. However, passing around components of
differential ports explicitly makes that harder.

Fixes #456.
Supersedes #457.

Co-authored-by: Jean THOMAS <git0@pub.jeanthomas.me>
@jfng
Copy link
Member

jfng commented Jul 31, 2020

@awygle @jfng there's some bulk change in this code which is unfortunately not robustly tested, can you give this a look before I merge?

LGTM, after exercizing it on ecp5-5g and artix7.

@whitequark whitequark merged commit d964ba9 into master Jul 31, 2020
@whitequark whitequark deleted the uniform-diff-ports branch July 31, 2020 18:42
@whitequark
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Negative side of diff pair is exposed on ECP5
3 participants