Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build,vendor: never carry around parts of differential signals #459

Merged
merged 1 commit into from Jul 31, 2020

Conversation

@whitequark
Copy link
Member

@whitequark whitequark commented Jul 31, 2020

When a port component is skipped, it should appear neither in the RTL nor in the constraint file. However, passing around components of differential ports explicitly makes that harder.

Fixes #456.
Supersedes #457.

@whitequark whitequark force-pushed the uniform-diff-ports branch from 83e5aa7 to de9c1a1 Jul 31, 2020
@whitequark
Copy link
Member Author

@whitequark whitequark commented Jul 31, 2020

@jeanthom PTAL

@awygle @jfng there's some bulk change in this code which is unfortunately not robustly tested, can you give this a look before I merge?

@jeanthom
Copy link

@jeanthom jeanthom commented Jul 31, 2020

Thanks for the PR, I can get #457 to work with it.

@whitequark
Copy link
Member Author

@whitequark whitequark commented Jul 31, 2020

Thanks for the PR, I can get #457 to work with it.

This PR includes #457.

@jeanthom
Copy link

@jeanthom jeanthom commented Jul 31, 2020

Oh I thought the PR only changed "p_port, n_port" => "port".

When a port component is skipped, it should appear neither in the RTL
nor in the constraint file. However, passing around components of
differential ports explicitly makes that harder.

Fixes #456.
Supersedes #457.

Co-authored-by: Jean THOMAS <git0@pub.jeanthomas.me>
@whitequark whitequark force-pushed the uniform-diff-ports branch from de9c1a1 to ba3729e Jul 31, 2020
@jfng
Copy link
Contributor

@jfng jfng commented Jul 31, 2020

@awygle @jfng there's some bulk change in this code which is unfortunately not robustly tested, can you give this a look before I merge?

LGTM, after exercizing it on ecp5-5g and artix7.

@whitequark whitequark merged commit d964ba9 into master Jul 31, 2020
10 checks passed
@whitequark whitequark deleted the uniform-diff-ports branch Jul 31, 2020
@whitequark
Copy link
Member Author

@whitequark whitequark commented Jul 31, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants