SSH Client Support via Paramiko #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
requested changes
Aug 1, 2020
whitequark
reviewed
Aug 1, 2020
whitequark
reviewed
Aug 1, 2020
whitequark
requested changes
Aug 1, 2020
whitequark
reviewed
Aug 17, 2020
whitequark
approved these changes
Aug 17, 2020
whitequark
reviewed
Aug 25, 2020
| # Forbid parent directory components completely to avoid the possibility | ||
| # of writing outside the build root. We can't use normpath to remove ".." | ||
| # because we may be running on Windows, but the remote is a *nix machine. | ||
| assert ".." not in filename.parts |
Member
There was a problem hiding this comment.
Instead of explaining why we don't use normpath here, let's just drop it in local builds as well. This way we don't have to explain anything, and the next person who copies the code for local builds doesn't introduce a similar bug, either.
Contributor
Author
There was a problem hiding this comment.
Fixed. os.path functions accepting Pathlib objects works down to and include Python 3.6, which is our cutoff. So might as well use it.
whitequark
approved these changes
Aug 26, 2020
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
execute_remote_sshmethod toBuildPlan, andRemoteSshBuildProductsclass tonmigen.build.run. Also addparamikotoextras_require.