Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix latency issues with AsyncFIFO #513

Merged
merged 2 commits into from
Oct 24, 2020

Conversation

anuejn
Copy link
Contributor

@anuejn anuejn commented Oct 23, 2020

This is the split out commit with testcase as requested for #512 in IRC

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #513 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
+ Coverage   81.33%   81.39%   +0.05%     
==========================================
  Files          49       49              
  Lines        6409     6413       +4     
  Branches     1278     1279       +1     
==========================================
+ Hits         5213     5220       +7     
+ Misses       1007     1005       -2     
+ Partials      189      188       -1     
Impacted Files Coverage Δ
nmigen/lib/fifo.py 93.93% <100.00%> (+0.53%) ⬆️
nmigen/build/run.py 22.05% <0.00%> (ø)
nmigen/sim/_pyrtl.py 95.80% <0.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c505de...09a1f10. Read the comment docs.

@anuejn anuejn changed the title Fix latency issues with AsyncFIF Fix latency issues with AsyncFIFO Oct 23, 2020
@whitequark whitequark merged commit d8273a1 into amaranth-lang:master Oct 24, 2020
@whitequark
Copy link
Member

Thanks @awygle for fixing this and @anuejn for splitting the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants