-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message. #537
Conversation
I run into this error every so often an thought this could be a more helpful error message.
Assuming anyone else runs into this... |
Or maybe it could say |
There's a warning (just below your change) that says the exact same thing, but also points to the |
Oh. You're right. My fault for not noticing that. |
I think I should do something with that warning, if people don't notice it, it's as good as not having it in first place... |
Maybe making it yellow? |
That's... hard to do in a good way. Think of the people with white terminals where it'll be unreadable. |
don't forget, you can change block backgrounds per character. |
Right. That will then break on Windows if I use direct escape sequences. And if I want to do it portably it'll be a new dependency and people would complain about that. Colors aren't a good solution. |
This is tricky... Is red not a good color? GCC and clang always seem to |
One thing I've learned is that no matter how liberal my assumptions about the downstream environment are, they are always insufficient to cover the workflow of a surprising amount of people. I think every nMigen tutorial that exists describes a completely different installation method, and that's just on Linux! |
Also, Windows Store has an official Python package, so if you just type |
You can also just ask nMigen users to read errors |
I think I've also seen error messages prefixed with |
Here is a horrible suggestion (but /might/ work); I would generally say that anything which isn't the in the last few lines of output is going to be very easily ignored? Maybe you could also having a |
Just before (i.e. above traceback) or just after (below traceback)? |
Just to confirm, I was ignoring what was above traceback UserWarning was above traceback. So collecting and going below might be better. |
I run into this error every so often and thought
this could be a more helpful error message.