Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement shape() for Record #545

merged 1 commit into from Nov 17, 2020


Copy link

@awygle awygle commented Nov 17, 2020

Record lost shape() in the migration to ValueCastable. This PR restores it.

Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #545 (d5ec68b) into master (4431814) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #545   +/-   ##
  Coverage   81.43%   81.44%           
  Files          49       49           
  Lines        6464     6466    +2     
  Branches     1290     1290           
+ Hits         5264     5266    +2     
  Misses       1010     1010           
  Partials      190      190           
Impacted Files Coverage Δ
nmigen/hdl/ 93.40% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4431814...d5ec68b. Read the comment docs.

@whitequark whitequark merged commit c1ed908 into amaranth-lang:master Nov 17, 2020
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants