Fixup symbiflow toolchain for xilinx 7series #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefix "tools" with symbiflow_ as is done for the QuickLogic Symbiflow toolchain. Installing symbiflow gives me the tools with the preifx, so I guess this is the correct way to move forward. Signed-off-by: Nick Østergaard <oe.nick@gmail.com>
nickoe
force-pushed
the
fixup_symbiflow_toolchain_xilinx_7series
branch
from
66a1543
to
b1af42f
Compare
Codecov Report
@@ Coverage Diff @@
## master #584 +/- ##
=======================================
Coverage 81.50% 81.50%
=======================================
Files 49 49
Lines 6461 6461
Branches 1287 1287
=======================================
Hits 5266 5266
+ Misses 1008 1007 -1
- Partials 187 188 +1
Continue to review full report at Codecov.
|
|
|
|
The original issue observed is fixed by f4pga/f4pga-arch-defs#1986 I think this pull request is ready to be merged. |
whitequark
approved these changes
Jan 31, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefix "tools" with symbiflow_ as is done for the QuickLogic Symbiflow
toolchain. Installing symbiflow gives me the tools with the preifx, so I
guess this is the correct way to move forward.
I tested this by adding
toolchain=Symbiflowto the constructor of basys3 (not upstreamed yet) and arty_a7 platform.There is a slight issue, but possibly with my symbiflow env where I see:There should be artix7 prefixed the chip name there. I assume this is an issue in the prjxray* or something. Possibly related to f4pga/f4pga-arch-defs#1947.Maybe @mglb wants to have a quick look at this as he submitted the original support for symbiflow in #463 ?