Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Instance driver-driver conflict error message #596

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

awygle
Copy link
Collaborator

@awygle awygle commented Feb 12, 2021

This PR attempts to address issues #405 , #398 , and #320 by improving error messages for driver-driver conflicts involving Instances.

I took my best stab at a better message, but am totally open to changing it.

I am almost sure an Instance conflict is the only case in which this code path is hit (I called out "input pin" because while it's the same issue under the hood it looks different to the user), but please do review closely.

No rush on this - not sure if it makes sense to go into 0.3 or not.

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #596 (ad07fcf) into master (f7c2b94) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #596   +/-   ##
=======================================
  Coverage   81.50%   81.50%           
=======================================
  Files          49       49           
  Lines        6461     6462    +1     
  Branches     1287     1288    +1     
=======================================
+ Hits         5266     5267    +1     
  Misses       1007     1007           
  Partials      188      188           
Impacted Files Coverage Δ
nmigen/hdl/ir.py 95.48% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7c2b94...ad07fcf. Read the comment docs.

Copy link
Contributor

@modwizcode modwizcode left a comment

Can you rebase? LGTM after rebase.

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #596 (1699ae4) into main (2adbe59) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #596   +/-   ##
=======================================
  Coverage   81.53%   81.53%           
=======================================
  Files          49       49           
  Lines        6468     6468           
  Branches     1531     1532    +1     
=======================================
  Hits         5274     5274           
+ Misses       1003     1002    -1     
- Partials      191      192    +1     
Impacted Files Coverage Δ
amaranth/hdl/ir.py 95.50% <100.00%> (+0.01%) ⬆️
amaranth/sim/pysim.py 93.17% <0.00%> (-0.11%) ⬇️
amaranth/lib/fifo.py 94.08% <0.00%> (ø)
amaranth/build/run.py 22.05% <0.00%> (ø)
amaranth/sim/_pycoro.py 80.00% <0.00%> (+0.23%) ⬆️
amaranth/sim/core.py 83.67% <0.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2adbe59...1699ae4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants