Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

back.rtlil: support slicing on Parts #650

Merged
merged 1 commit into from Dec 11, 2021

Conversation

modwizcode
Copy link
Contributor

@modwizcode modwizcode commented Dec 11, 2021

Fixes #605.

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2021

Codecov Report

Merging #650 (aef49e3) into main (599615e) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #650      +/-   ##
==========================================
+ Coverage   81.52%   81.53%   +0.01%     
==========================================
  Files          49       49              
  Lines        6457     6468      +11     
  Branches     1528     1531       +3     
==========================================
+ Hits         5264     5274      +10     
- Misses       1002     1003       +1     
  Partials      191      191              
Impacted Files Coverage Δ
amaranth/back/rtlil.py 80.49% <0.00%> (-0.07%) ⬇️
amaranth/sim/_pyrtl.py 95.26% <0.00%> (-0.48%) ⬇️
amaranth/build/run.py 22.05% <0.00%> (ø)
amaranth/build/dsl.py 96.22% <0.00%> (+0.04%) ⬆️
amaranth/sim/core.py 83.33% <0.00%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 599615e...aef49e3. Read the comment docs.

Copy link
Member

@whitequark whitequark left a comment

LGTM

@whitequark whitequark merged commit 0b74d1c into amaranth-lang:main Dec 11, 2021
7 checks passed
@whitequark
Copy link
Member

whitequark commented Dec 11, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Nesting Parts with a variable offset throws an AssertionError
3 participants