Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor.xilinx: add workaround for ISE #652

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

modwizcode
Copy link
Contributor

@modwizcode modwizcode commented Dec 13, 2021

ISE doesn't support using the constraints file to specify attributes on
IO buffers, this works around that by specifying them also as module
parameters which ISE does support properly.

Fixes #641.

Note: This is a horrible hack in my opinion and is currently untested on ISE (in-progress). Comments welcome.

ISE doesn't support using the constraints file to specify attributes on
IO buffers, this works around that by specifying them also as module
parameters which ISE does support properly.

Fixes amaranth-lang#641.
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #652 (e8d8881) into main (0b74d1c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #652   +/-   ##
=======================================
  Coverage   81.53%   81.53%           
=======================================
  Files          49       49           
  Lines        6468     6468           
  Branches     1531     1531           
=======================================
  Hits         5274     5274           
- Misses       1002     1003    +1     
+ Partials      192      191    -1     
Impacted Files Coverage Δ
amaranth/build/run.py 22.05% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b74d1c...e8d8881. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants