Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

back.{rtlil,verilog}: deprecate implicit ports. #658

Merged
merged 1 commit into from Dec 13, 2021

Conversation

modwizcode
Copy link
Contributor

@modwizcode modwizcode commented Dec 13, 2021

Fixes #630.

@modwizcode modwizcode force-pushed the deprecate-ports branch 2 times, most recently from 4f5f72b to fb06005 Compare Dec 13, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #658 (456449a) into main (24c4da2) will decrease coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #658      +/-   ##
==========================================
- Coverage   81.53%   81.48%   -0.06%     
==========================================
  Files          49       49              
  Lines        6467     6475       +8     
  Branches     1531     1533       +2     
==========================================
+ Hits         5273     5276       +3     
- Misses       1003     1005       +2     
- Partials      191      194       +3     
Impacted Files Coverage Δ
amaranth/back/rtlil.py 79.81% <50.00%> (-0.69%) ⬇️
amaranth/back/verilog.py 65.62% <75.00%> (+6.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c4da2...456449a. Read the comment docs.

Copy link
Member

@whitequark whitequark left a comment

LGTM

@whitequark whitequark merged commit d83c4a1 into amaranth-lang:main Dec 13, 2021
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants