Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'ports' argument getting lost as it's no longer 'kwargs' #659

Closed
wants to merge 1 commit into from

Conversation

gatecat
Copy link

@gatecat gatecat commented Dec 13, 2021

Fixes #658; because ports isn't part of kwargs any more it ends up going missing and, ironically, an implicitly determined set of ports is used instead.

Signed-off-by: gatecat <gatecat@ds0.me>
@gatecat
Copy link
Author

gatecat commented Dec 13, 2021

Looking at the test failure, I think the tests should be modified to specify ports explicitly?

@whitequark whitequark added this to the 0.3 milestone Dec 14, 2021
@gatecat gatecat deleted the port-fix branch Dec 14, 2021
@whitequark
Copy link
Member

whitequark commented Dec 14, 2021

Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants