Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error for subscribe #649

Closed
mccoysc opened this issue Dec 1, 2018 · 6 comments
Closed

error for subscribe #649

mccoysc opened this issue Dec 1, 2018 · 6 comments

Comments

@mccoysc
Copy link

mccoysc commented Dec 1, 2018

gun.get('topic').get('data').map().on(function(d){
console.log(d)
});

gun.get('topic').get('data').set(1).

the above code would work well.
but,after the following code,the on's callback function would nerver be called any more:

gun.get('topic').get('data').put(null).

though i call any times of :
gun.get('topic').get('data').set(1),gun.get('topic').get('data').set(2) and so on……nothing is working

@mccoysc
Copy link
Author

mccoysc commented Dec 1, 2018

in fact,i expect that after .put(null),if call .set(1),all data in set would be in new state but not,it just don't work any more what ever i call any function.

@mccoysc
Copy link
Author

mccoysc commented Dec 2, 2018

Really,i need delete the old data in a key.for example:
a chat app,you have a session that the chat history grow and grow and maybe it's up to 1000000 and more,this is not acceptable if all data live in a key.

@mccoysc
Copy link
Author

mccoysc commented Dec 5, 2018

@amark

@amark
Copy link
Owner

amark commented Dec 6, 2018

Hmm, I'm pretty sure I have a test for this in core, because it took like 5 months of my life to figure out how to solve for this.

But my philosophy is to assume any reports like big thanks from @mccoysc is true because tests only test what they know to test, and there is nothing more thorough than people like you helping find edge cases! So thank you, IDK how soon I can get to this though :/ pretty back logged with stuff just getting back from Japan. I was gone this last week, sorry for the delay to reply - forgive me.

@amark
Copy link
Owner

amark commented Dec 8, 2018

I'm hoping my fix for #632 will fix this as well, when next version gets published please retry.

@amark
Copy link
Owner

amark commented Dec 14, 2018

I published the SEA security fixes earlier today, they should have included the previous fix for this + #632 and it should now be available in latest ...92 version.

Please upgrade and try again! Should be fixed, so closing - please reopen if you notice any other problems.

Thanks again @mccoysc for reporting this!!! :) :) :) Grateful for people hunting down and reporting problems, even if it takes me a while to fix/patch them.

@amark amark closed this as completed Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants