Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests for cursor and descending ordering #760

Open
wants to merge 1 commit into
base: master
from

Conversation

@mmalmi
Copy link
Collaborator

commented Jun 10, 2019

No description provided.

@amark amark referenced this pull request Jul 17, 2019
@amark

This comment has been minimized.

Copy link
Owner

commented Sep 7, 2019

@mmalmi you are the first to hear about this.

Sure enough, in my tests debugging RAD, I came across a faulty condition handling reverse radix traversal. If you had [alice, zach, zachary] it would go in reverse order by prefix but handle each parent prefix first ( -> zach, zachary, alice) cause my reverse test didn't use nested values. But I just fixed this a few seconds ago (locally) and added a test for the in-memory radix tree.

I'm hoping this fixes reverse pagination... and I'm hoping ??? maybe this'll be the last RAD bug to squish before publishing. I hope I hope, gotta run ton of other tests & experiments. I hope I hope I hope... months working on this...

@amark

This comment has been minimized.

Copy link
Owner

commented Sep 10, 2019

@mmalmi nope :( this didn't fix the original issue, but at least in my attempts to fix it it got these other things fixed :P

@mmalmi

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 12, 2019

With latest gun version:

1) read contacts smaller than cursor [fail]
✓ read contacts in descending order [pass]

Should we still merge these tests to master?

@mmalmi mmalmi force-pushed the mmalmi:master branch from 7504672 to 50e7ccb Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.