Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added better error handling into put #825

Merged
merged 1 commit into from Sep 30, 2019

Conversation

@Dletta
Copy link
Contributor

commented Sep 29, 2019

with the original code if ack.err occured, it would throw a bigger error since the rejection of the promise wasn't caught.

@amark

This comment has been minimized.

Copy link
Owner

commented Sep 30, 2019

you're awesome!

@amark amark merged commit d7de5e7 into amark:master Sep 30, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.