New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failures. #25

Merged
merged 2 commits into from Oct 28, 2018

Conversation

Projects
None yet
2 participants
@hshimoyama
Contributor

hshimoyama commented Oct 28, 2018

This PR fixes test failures on Travis CI.

  • Add required development dependency for all test cases.
  • Update test configuration about Capybara webdriver for test cases running with Rails 5.2 and later.

hshimoyama and others added some commits Oct 26, 2018

Fix test failures.
  - Update driver for ActionDispatch::SystemTestCase.
  - Remove unused Capybara custome driver.

Co-authored-by: y-yagi <yuuji.yaginuma@gmail.com>
@amatsuda

This comment has been minimized.

Owner

amatsuda commented Oct 28, 2018

@y-yagi @hshimoyama Thank you!!

@amatsuda amatsuda merged commit 00ff910 into amatsuda:master Oct 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hshimoyama hshimoyama deleted the hshimoyama:fix_test branch Oct 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment