% in URL #327

Closed
palexvs opened this Issue Dec 21, 2012 · 4 comments

2 participants

@palexvs

If URL has %25 (escaped %) paginator generate links without escaping %.

If i have page with url:
http://some.domain.com/50%25+sales

in paginator I got
http://some.domain.com/50%+sales?page=2

@palexvs palexvs closed this Dec 23, 2012
@palexvs palexvs reopened this Dec 23, 2012
@palexvs

My solutions is
paginate @entities, :params => { :keyword => CGI.escape(@keyword) }

@yuki24
Collaborator

It turns out that this could be a Rails bug. I think you have a route like http://some.domain.com/:keyword, is that correct? If so, try something like:

url_for(:keyword => @keyword)

Then you'll see a string that is not escaped.

@palexvs

Yea, you are totally right
Thank you!

@yuki24
Collaborator

I'm closing this issue since kaminari doesn't have to take care of URL escaping.

@yuki24 yuki24 closed this Jun 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment