Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

page_entries_info uses .empty? which bypasses total_count magic, leading to invalid SQL sometimes. #349

Closed
mgates opened this Issue · 3 comments

2 participants

@mgates

Because it doesn't have the checks in place to remove a double distinct, it generates invalid sql.

(patch forthcoming)

@mgates

related to #104 and #77

@mgates

Same with any?, which isn't used by kaminari, but should use total_count, I think.

@yuki24
Collaborator

I'm closing this issue because page_entries_info no longer uses .empty? and I don't think we still have this issue.. Thanks!

@yuki24 yuki24 closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.