Skip to content

Use page 1 in the params #229

Closed
wants to merge 1 commit into from

1 participant

@rhulse
rhulse commented Apr 18, 2012

When creating the pagination links, page 1 is not included for the links that go to page 1. This means that whatever is being paginated has to know that when no page param is set, it mean page one.

It is better form to explicitly set the page number all the time, ensuring that it will always work regardless of the underlying implementation.

@ghost
ghost commented Apr 18, 2012

#222, We have the same thinking~

@rhulse
rhulse commented Apr 18, 2012

I'll close this and go and +1 yours! :-)

@rhulse rhulse closed this Apr 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.