Skip to content

Issue #310 fixed. Refactored code to use a single method to know if a ta... #354

Closed
wants to merge 1 commit into from

3 participants

@anthonyalberto

Wrote specs for the new methods. Tell me if I missed anything!

@anthonyalberto anthonyalberto Issue #310 fixed. Refactored code to use a single method to know if a…
… tag page should be displayed.

310 - Fixed. Need to write some tests now.

310 - Fixed. Need to write some tests now.

Stubbed Specs

All tests are passing
5d6c1ce
@anthonyalberto

Fixes #310

@yuki24 yuki24 was assigned Jun 21, 2013
@zzak
Collaborator
zzak commented Aug 7, 2013

I don't like this change, refactoring a should remove code not add complexity.

@zzak zzak closed this Aug 7, 2013
@yuki24
Collaborator
yuki24 commented Aug 7, 2013

@zzak I don't think this is actually refactoring, but tweaking how paginate displays gaps/page numbers, and I like the idea. I guess we can do something better, though.

@zzak
Collaborator
zzak commented Aug 7, 2013

I'm not opposed to the idea, just the patch. Please submit a new patch.

@yuki24 yuki24 reopened this Mar 30, 2014
@yuki24
Collaborator
yuki24 commented Mar 31, 2014

picked up some of this pull request and manually merged 0689b23.

@yuki24 yuki24 closed this Mar 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.