Require dm-core instead of data_mapper to detect DataMapper #372

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@jlukas

Requiring data_mapper pulls in unnecessary dependencies. All that's truly needed is dm-core and dm-aggregates (which is already required).

@zzak
Collaborator

This adds no extra value, some apps may already require the rest of data_mapper, so lets just leave it until the next major release.

We plan to refactor to gems.

@zzak zzak closed this Aug 7, 2013
@jlukas

The reason for this change is that one gem I require conflicts with dm-serializer, which data_mapper pulls in automatically. Changing this to requiring dm-core allows me to use kaminari.

@zzak
Collaborator

@jlukas can you show us your code, or a reproducible example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment