Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

remove unused href attribute on gap partial #17

Merged
merged 1 commit into from

2 participants

@jgrevich

I exchanged link_to's for content_tag :a's in order to remove the href.
This is related to @znz's request to remove unused href and add classes in issue #12

@jgrevich jgrevich remove unused href attribute on gap partial
I exchanged link_to's for content_tag :a's in order to remove the href.
a5b0867
@jgrevich

@amatsuda I don't see why this one cannot be merged as well. We can close out two open issues.

@seuros seuros merged commit 3978756 into amatsuda:master
@seuros
Collaborator

Thank you

@ShPakvel ShPakvel referenced this pull request from a commit in ShPakvel/kaminari_themes
@ShPakvel ShPakvel correct _page templates similar to merged pull #17 327bf9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 19, 2013
  1. @jgrevich

    remove unused href attribute on gap partial

    jgrevich authored
    I exchanged link_to's for content_tag :a's in order to remove the href.
This page is out of date. Refresh to see the latest.
View
4 bootstrap/app/views/kaminari/_gap.html.erb
@@ -1,3 +1 @@
-<li class="disabled">
- <%= link_to raw(t 'views.pagination.truncate'), '#' %>
-</li>
+<%= content_tag :li, content_tag( :a, raw(t 'views.pagination.truncate')), class: :disabled %>
View
2  bootstrap/app/views/kaminari/_gap.html.haml
@@ -1,2 +1,2 @@
%li.disabled
- = link_to raw(t 'views.pagination.truncate'), '#'
+ = content_tag :a, raw(t 'views.pagination.truncate')
Something went wrong with that request. Please try again.