Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overridden-routes-checker #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

overridden-routes-checker #39

wants to merge 1 commit into from

Conversation

andreitsepliakou
Copy link

A new rule checks that there are no routes that override each other.
The overriding can be caused by an incorrect routes order in routes.rb.

E.g.

# config/routes.rb

# bad: 'import' keyword is considered as an invalid user id. 404 seems to be caused.
get "/users/:user_id/purchases", to: "purchases#index"
get "/users/import/purchases", to: "user_import_purchases#index"

# good: some 'import page' is rendered by some UserImportPurchasesController successfully
get "/users/import/purchases", to: "user_import_purchases#index"
get "/users/:user_id/purchases", to: "purchases#index"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant