Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not load acme routes to fill `LAGOON_ROUTES` #1000

Closed
Schnitzel opened this Issue Mar 28, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@Schnitzel
Copy link
Member

Schnitzel commented Mar 28, 2019

currently here:

ROUTES=$(oc --insecure-skip-tls-verify -n ${OPENSHIFT_PROJECT} get routes -o=go-template --template='{{range $index, $route := .items}}{{if $index}},{{end}}{{if $route.spec.tls.termination}}https://{{else}}http://{{end}}{{$route.spec.host}}{{end}}')

we just load all routes that exist. If there is an acme (lets encrypt) TLS certification creating at the same time there is a second route existing which has the same domain and thus it will report the route a second time.
this is a bit confusing and also caused some issues in some cases.

Therefore let's ignore routes that have the label acme.openshift.io/exposer: 'true' (which is set by the acme tool)

@rtprio rtprio self-assigned this Mar 28, 2019

@rtprio rtprio closed this Mar 28, 2019

@rtprio rtprio reopened this Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.