Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git links in lagoon-ui display incorrectly #1066

Closed
shreddedbacon opened this issue Apr 30, 2019 · 0 comments · Fixed by #1156

Comments

@shreddedbacon
Copy link
Member

commented Apr 30, 2019

Git Origin and Source links in Project and Environment pages in the lagoon UI are displaying with a colon which causes them to fail when clicking them.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'http://${ui-url}/projects/${project-name}'
  2. Look at the "ORIGIN" URL
  3. Observe an additional colon in the path
    image
  4. Click on an environment in the project
  5. View the source url with an additional colon
    image

Expected behavior
There should be no additional colon in the URL

Additional context
The extra colon does not appear if the git URL has a port defined
image

It looks like there may be a problem with the way git-url-parse is handling some URLs

const gitLink = `${gitUrlParsed.resource}/${gitUrlParsed.full_name}`;

const gitBranchLink = `${gitUrlParsed.resource}/${
gitUrlParsed.full_name
}/tree/${environment.name}`;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.