Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutation deleteProject fails to delete project #1227

Closed
shreddedbacon opened this issue Sep 6, 2019 · 0 comments · Fixed by #1230

Comments

@shreddedbacon
Copy link
Member

commented Sep 6, 2019

Describe the bug
When attempting to delete a project in v1.0.0 it returns project is not defined

To Reproduce
Steps to reproduce the behavior:

  1. Create a project
  2. Attempt to remove the project
mutation {
	deleteProject(input:{project:"example-project"})
}
  1. See error
{
  "errors": [
    {
      "message": "project is not defined",
      "locations": [
        {
          "line": 235,
          "column": 2
        }
      ],
      "path": [
        "deleteProject"
      ]
    }
  ],
  "data": {
    "deleteProject": null
  }
}

Expected behavior
Project should be deleted

Additional context
https://github.com/amazeeio/lagoon/blob/master/services/api/src/resources/project/resolvers.js#L351
Removing the line const project = await Helpers(sqlClient).getProjectById(pid); allows the project to be deleted successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.