Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon for Lagoon UI #1305

Closed
seanhamlin opened this issue Oct 16, 2019 · 1 comment · Fixed by #1399
Closed

Add favicon for Lagoon UI #1305

seanhamlin opened this issue Oct 16, 2019 · 1 comment · Fixed by #1399
Assignees
Labels
ui

Comments

@seanhamlin
Copy link
Contributor

@seanhamlin seanhamlin commented Oct 16, 2019

Describe the bug
Visit the Lagoon UI in your browser, notice no favicon is present

To Reproduce
Steps to reproduce the behaviour:

  1. Visit https://ui-lagoon-master.ch.amazee.io/favicon.ico
  2. See HTTP 404

Expected behavior
HTTP 200, and the new Lagoon image present.

@seanhamlin seanhamlin added the ui label Oct 16, 2019
@JohnAlbin

This comment has been minimized.

Copy link
Contributor

@JohnAlbin JohnAlbin commented Oct 16, 2019

It's easy to make a favicon from the new Lagoon logo. https://stories.amazee.io/a-logo-for-lagoon-40e892ec2691

I will create a PR for this. Unless, @seanhamlin, you are already working on it?

@JohnAlbin JohnAlbin self-assigned this Oct 16, 2019
JohnAlbin added a commit that referenced this issue Nov 14, 2019
@JohnAlbin JohnAlbin mentioned this issue Nov 14, 2019
3 of 3 tasks complete
JohnAlbin added a commit that referenced this issue Nov 14, 2019
JohnAlbin added a commit that referenced this issue Nov 19, 2019
JohnAlbin added a commit that referenced this issue Nov 20, 2019
JohnAlbin added a commit that referenced this issue Nov 25, 2019
JohnAlbin added a commit that referenced this issue Nov 26, 2019
JohnAlbin added a commit that referenced this issue Nov 27, 2019
Schnitzel added a commit that referenced this issue Dec 1, 2019
Add Lagoon favicon. Fixes #1305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.