Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download button on backups page displays different #1463

Closed
shreddedbacon opened this issue Dec 6, 2019 · 3 comments · Fixed by #1465
Closed

Download button on backups page displays different #1463

shreddedbacon opened this issue Dec 6, 2019 · 3 comments · Fixed by #1465
Assignees
Labels
ui

Comments

@shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Dec 6, 2019

Describe the bug
Styling on the Download button once a backup has been retrieved is different to the when it is shown as Retrieve and Retrieving

This results in multiple backups displaying close together when they are ready to download. See attached screenshots

Screenshots
image
image

@shreddedbacon shreddedbacon added the ui label Dec 6, 2019
@rocketeerbkw

This comment has been minimized.

Copy link
Member

@rocketeerbkw rocketeerbkw commented Dec 6, 2019

What OS and browser versions are you using?

@JohnAlbin

This comment has been minimized.

Copy link
Contributor

@JohnAlbin JohnAlbin commented Dec 6, 2019

What OS and browser versions are you using?

I can confirm this is happening on Chrome. I know how to fix it too; the download button is an a tag which defaults to display: inline, while the other buttons are button tags which defaults to display: inline-block. I'll do a quick PR.

@JohnAlbin JohnAlbin self-assigned this Dec 6, 2019
JohnAlbin added a commit that referenced this issue Dec 6, 2019
@shreddedbacon

This comment has been minimized.

Copy link
Member Author

@shreddedbacon shreddedbacon commented Dec 6, 2019

Yup, was chrome for me too, sorry should have specified.

JohnAlbin added a commit that referenced this issue Dec 10, 2019
JohnAlbin added a commit that referenced this issue Dec 11, 2019
JohnAlbin added a commit that referenced this issue Dec 12, 2019
Schnitzel added a commit that referenced this issue Dec 13, 2019
Fix display of download button on Backups page. #1463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.