Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keycloak service name is hard-coded in the API service #2133

Closed
smlx opened this issue Aug 5, 2020 · 0 comments · Fixed by #2191
Closed

Keycloak service name is hard-coded in the API service #2133

smlx opened this issue Aug 5, 2020 · 0 comments · Fixed by #2191
Labels
1-api-auth API & Authentication subsystem

Comments

@smlx
Copy link
Member

smlx commented Aug 5, 2020

Describe the bug
The keycloak service name is hard-coded in the API client. This means that it cannot be set via environment variables in the usual 12-factor way.

To Reproduce
Steps to reproduce the behavior:

  1. Name the keycloak service anything other than keycloak.
  2. See error on api service startup.

Expected behavior
I expect that the default keycloak service name would be able to be overridden by environment variable.

Screenshots
n/a

Additional context
The keycloak service is hard-coded here:
https://github.com/amazeeio/lagoon/blob/master/services/api/src/clients/keycloakClient.js#L7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-api-auth API & Authentication subsystem
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant